Skip to content

CLN: Remove type from (class|type) in regexes #26434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2019
Merged

CLN: Remove type from (class|type) in regexes #26434

merged 1 commit into from
May 17, 2019

Conversation

simonjayhawkins
Copy link
Member

xref #25725

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26434 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26434      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46548    46543       -5     
- Misses       4193     4198       +5
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.69% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.6% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1263e1a...a75a3b2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #26434 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26434      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46548    46543       -5     
- Misses       4193     4198       +5
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.69% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.6% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1263e1a...a75a3b2. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone May 17, 2019
@jreback jreback merged commit 6b2445d into pandas-dev:master May 17, 2019
@jreback
Copy link
Contributor

jreback commented May 17, 2019

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the type-regex branch May 17, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jreback